Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!
Всего: 128
−100
#Было
def extract_brand(x):
x = x[0].lower()
for brand in brands:
if x.count(brand):
return brand
il.brand_out = extract_brand
#Стало после кодревью
il.brand_in = lambda x: [brand for brand in brands if brand.lower() in x[0].lower()]Кто то смог прочитать второй вариант?
kyzi007,
22 Июня 2014
−94
l.category_out = lambda x: filter(lambda y: y != u'»', x)
kyzi007,
28 Мая 2014
−102
l.add_xpath('price', '//table[3]/tr/td[2]/table[1]/tr[1]/td[3]/table/tr[3]/td/table/tr[2]/td/text()', lambda x: '.'.join(x))
kyzi007,
05 Мая 2014
−103
li = item_parser.select('//li')
for i in li:
try:
i.extract().index(u'Цены')
item.price = i.select('span/text()').extract()[0]
except ValueError:
pass
try:
i.extract().index(u'Модификации')
item.modification = i.select('span/text()').extract()[0]
except ValueError:
pass
try:
i.extract().index(u'Отзывы')
item.reviews = i.select('span/text()').extract()[0]
except ValueError:
passНиосилила utf...
kyzi007,
07 Марта 2014
−118
public static function cancel (tween : T) : void {
delete _dict[tween];
}
public function cancel () : void {
delete _dict[this];
}Пыщ пыщ, я развлекаюсь
kyzi007,
23 Декабря 2013
−119
if (repeatCount > 1 && repeatCount > mediator.data.repeat_count && sequence.completeAction == "END") {
mediator.data.repeat_count = mediator.data.repeat_count + 1;
mediator.currentSequenceStep = mediator.currentSequenceStep;
}
else if (repeatCount > 1 && repeatCount > mediator.data.repeat_count) {
mediator.data.repeat_count = mediator.data.repeat_count + 1;
mediator.currentSequenceStep = mediator.currentSequenceStep;
}Я плакать. Я убивать.
kyzi007,
19 Сентября 2013
−91
private function checkResourcesForIcon():void {
if (!(this is TotemMediator)) {
if ((!Player.instance.friendMode && buildable && step && step.bubbleIco) || _ico) {
sendNotification(GameNotifications.ADD_RESOURCE_CHECKER, {
'caller_id': id, 'res_v': step.requirement,
'action_0': { 'notification': ObjectNotifications.UPDATE_ICON, 'body': {'id': id, 'check': false } },
'action_1': { 'notification': ObjectNotifications.UPDATE_ICON, 'body': {'id': id, 'check': true } }
});
}
}
}
// команда на GameNotifications.ADD_RESOURCE_CHECKER
override public function execute(notification:INotification):void {
super.execute(notification);
var body:Object = notification.getBody();
var resChecker:ResourceChecker = this.facade.retrieveProxy(ResourceChecker.NAME) as ResourceChecker;
resChecker.addChecker(body.caller_id, body.res_v, body.action_0, body.action_1);
}
// ResourceChecker
public function addChecker(callerId:String, resV:Vector.<ResourceData>, action0:Object, action1:Object):void {
if (!callersToCheck) {
callersToCheck = { };
}
//overwrite
callersToCheck[callerId] = { 'res':resV, 'action0':action0, 'action1':action1, 'enough':false };
//recheck
checkCaller(callerId);
}
private function checkCaller(callerId:String):void {
if (callersToCheck[callerId]) {
var checkV:Vector.<ResourceData> = callersToCheck[callerId]['res'];
var allEnough:Boolean = true;
for each(var checkR:ResourceData in checkV) {
if (checkR.resourcetype != 'WORKER') { //TODO: wtf with worker?
//if no such res or res not enough OR this is not completed quest
if ((!storedResources[checkR.resourcetype] || storedResources[checkR.resourcetype].quantity < checkR.quantity) && storedQuests.indexOf(checkR.resourcetype) == -1) {
allEnough = false;
break;
}
}
}
if (allEnough && !callersToCheck[callerId]['enough']) {
callersToCheck[callerId]['enough'] = true;
executeAction(callersToCheck[callerId]['action1']);
}else if (!allEnough && callersToCheck[callerId]['enough']) {
callersToCheck[callerId]['enough'] = false;
executeAction(callersToCheck[callerId]['action0']);
}
}
}
// и наконец
private function executeAction(action:Object):void {
if (action) {
if (action['directive']) {
Facade.getInstance().sendNotification(GameNotifications.RUN_DIRECTIVE, {name: action['directive'], args: action['args'] });
} else if (action['notification']) {
Facade.getInstance().sendNotification(action['notification'], action['body']);
}
}
}
kyzi007,
01 Августа 2013
−120
manageAsset: {
var clip : MovieClip = content as MovieClip;
if (clip && clip.hasOwnProperty(LIB_PROP)) {
var lib : Object = clip[LIB_PROP];
ObjectUtils.update(this._library, lib);
this._assets[url] = lib;
for each (var name : String in lib) {
this._fileByAsset[name] = url;
}
break manageAsset;
} else if (clip) {
this._loadingTargets[url] = e.target;
}
var bitmap : Bitmap = content as Bitmap;
if (bitmap) {
this._libraryBitmap[url] = bitmap.bitmapData;
break manageAsset;
}
var sound : Sound = content as Sound;
if (sound) {
this._sounds[url] = sound;
break manageAsset;
}
}Вот такой вариант инлайновго ретурна (это юзаются метки цикла на пустом эээ выражении если что). Когда первый раз увидела вывесило в ступор минут на пять - не знала что вообще так можно.
kyzi007,
05 Июля 2013
−124
private function checkClickCondition():Boolean {
if ((isBildable(_focus) && GameObjectMediator(_focus).step && GameObjectMediator(_focus).step.isLock && isEditObjectMode(objectEditorMode))|| isTile(_focus)|| isHelper(_focus)) {
return true;
}
return false;
}
private function isEditObjectMode(objectEditorMode:String):Boolean {
return (objectEditorMode == LevelMediator.MOVE_OBJECTS|| objectEditorMode == LevelMediator.ROTATE_OBJECTS|| objectEditorMode == LevelMediator.CREATE_OBJECTS|| objectEditorMode == LevelMediator.PLACE_OBJECT|| objectEditorMode == LevelMediator.STORE_OBJECTS|| objectEditorMode == LevelMediator.SELL_OBJECTS)
}
private function isHelper(val:ISortable):Boolean {return (val && val is HelperMediator);}
private function isTile(val:ISortable):Boolean {return (val && !(val is GameObjectMediator));}
private function isBildable(val:ISortable):Boolean {return (val && val is GameObjectMediator);}
protected function onClick(e:MouseEvent = null):void {
var focusTile:TileMediator = _focus as TileMediator;
if (_mouseClickLockedFromTutor && _focus != _tutorMagicObject) return;
if (_mouseClickLockedlockAllExceptFowFromTutor) {
if (!_focus) {
this.sendNotification(CellNotifications.CLICK, this._currentCell);
return;
}
if (!(_focus is FowObject)) return;
}
if (focusTile || this._newObjectPreview) {
if (checkClickCondition()) {
switch (this.objectEditorMode) {
case LevelMediator.MOVE_OBJECTS:
if (this._newObjectPreview) {
if (this.greenPlace) {
this.moveObject();
}
}
else if (focusTile.isMovable && !focusTile.data.worker) {
_movedObject = focusTile;
focusTile.removeHighlight();
_hittest.removeObject(_focus);
_focus = null;
focusTile.data.clearCells();
_movedObject.onStartDragging();
this.trackMode = TRACKING_DISABLED;
setNewObjectAsset(focusTile.buildable.id, AnimationsList.IDLE, _movedObject.currentAnimationStep);
if (_movedObject is GameObjectMediator && GameObjectMediator(_movedObject).flip) {
this._newObjectPreview.view.flip = GameObjectMediator(_movedObject).flip;
}
}
break;
case LevelMediator.ROTATE_OBJECTS:
if (focusTile.isRotateble && !focusTile.data.worker) {
this.rotateObject(this._focus as GameObjectMediator);
}
break;
case LevelMediator.CREATE_OBJECTS:
if (this._newObjectPreview && greenPlace) {
this.createBuyObject();
}
break;
case LevelMediator.PLACE_OBJECT:
if (this._newObjectPreview && greenPlace) {
this.placeInventoryObject();
}
break;
case LevelMediator.STORE_OBJECTS:
if (focusTile.isStorable && !focusTile.data.worker) {
sendNotification(SoundNotifications.SOUND_PLAY, Sounds.SND_ITEM_STORE);
sendNotification(GameNotifications.RUN_DIRECTIVE, {
name: DStorageItem.NAME,
args: {id: _focus.id}}
);
}
break;
case LevelMediator.SELL_OBJECTS:
if (focusTile.isSellable && !focusTile.data.worker) {
sendNotification(GameNotifications.RUN_DIRECTIVE, {
name: DSellBuildable.NAME,
args: {
id: _focus.id,
buildableId: focusTile.buildable.id,
value: 1,
confirmation: true}
});}
break;
default:
if (this._focus is HelperMediator) {
(this._focus as HelperMediator).onClick();
sendNotification(GameObjectNotifications.ON_CLICK, {id: _focus.id});}
else {
var gom:GameObjectMediator = _focus as GameObjectMediator;
if (gom && (gom.complete || gom.step != null && !focusTile.data.worker)) {
if (!gom.wait) {
Debug.log('LevelMediator.onClick: ObjectNotifications.CLICK ' + focusTile.data);
this.sendNotification(ObjectNotifications.CLICK, focusTile.data);
}
else if (Settings.ingamelog) {
this.sendNotification(UINotifications.SHOW_CONFIRMATION_WINDOW, {
title: 'speedup',
description: 'for testing purposes',
res: focusTile.buildable,
action: {
notification: UINotifications.TEST_SPEED_UP,
body: this._focus}Сижу, меняю условия так чтобы за квестовыми объектами можно было проставлять декор...
kyzi007,
03 Июля 2013
−127
protected function updateTimer():void {
if (this._waitAction) {
EnterFrame.removeScheduledAction(this._waitAction);
this._waitAction = null;
}
if (this._wait > 0) {
this._waitAction = EnterFrame.scheduleAction(this._wait - getTime(), this.onWaitComplete);
this._waitAction.name = 'GameObjectMediator:updateTimer';
}
else {
this._waitAction = null;
}
this.playDefaultAnimation();
if (this._filters) {
this.highlight(this._filters);
}
if (!(this is TotemMediator)) {
if (!Player.instance.friendMode && this.buildable && this.buildable.tags.find(Buildable.TAG_INDICATOR) &&
(this._complete || (this._wait == 0 && !this._actionProgress && this.data.step))){
if (!this._ico) {
if (!this._complete) {
if (this.data.step.waitTimeMs > 0) {
switch(this.buildable.id) {
case 'building_smithy':
this._ico = new GameObjectIco(GameObjectIco.TYPE_COLLECT_AXES, this);
break;
case 'building_alchemist':
case 'quest_building_well_magicwell':
this._ico = new GameObjectIco(GameObjectIco.TYPE_COLLECT_MANA, this);
break;
default:
this._ico = new GameObjectIco(GameObjectIco.TYPE_COLLECT_RESOURCES, this);
break;
}
}else {
this._ico = new GameObjectIco(GameObjectIco.TYPE_BUILD, this); // case for ruins
}
}else {
this._ico = new GameObjectIco(GameObjectIco.TYPE_COLLECT_RESOURCES, this);
}
if (this._filters) {
this._ico.view.filters = this._filters;
}
this.alignIco();
}
}
else {
this.removeIco();
}
}
}4 дня до релиза...
kyzi007,
27 Июня 2013
Follow us!