1. Список говнокодов пользователя hrustbb2

    Всего: 3

  2. PHP / Говнокод #26940

    0

    1. 1
    2. 2
    3. 3
    foreach ($properties->xml->ЗначенияСвойства as $property) {
        //......
    }

    $properties->xml->ЗначенияСвойства

    hrustbb2, 10 Сентября 2020

    Комментарии (12)
  3. PHP / Говнокод #26903

    −1

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18
    19. 19
    20. 20
    21. 21
    22. 22
    23. 23
    24. 24
    25. 25
    26. 26
    27. 27
    28. 28
    29. 29
    30. 30
    31. 31
    32. 32
    33. 33
    34. 34
    35. 35
    36. 36
    37. 37
    38. 38
    39. 39
    40. 40
    41. 41
    42. 42
    43. 43
    44. 44
    45. 45
    46. 46
    47. 47
    48. 48
    49. 49
    50. 50
    51. 51
    52. 52
    53. 53
    54. 54
    55. 55
    56. 56
    57. 57
    58. 58
    59. 59
    60. 60
    61. 61
    62. 62
    63. 63
    64. 64
    65. 65
    66. 66
    67. 67
    68. 68
    69. 69
    70. 70
    71. 71
    72. 72
    public function index()
        {
            $items = CartManager::getAllItems();
    
            $couponCode = Coupon::getFromSession()->implode('code', ', ');
    
            $address = auth()->user()->address;
    
            $user = auth()->user();
            $userDetails = auth()->user() ? auth()->user()->fields : null;
    
            $fields = [
                'promo_code' => $couponCode,
                'email' => $user->email,
                'first_name' => $userDetails->firstname,
                'last_name' => $userDetails->lastname,
                'phone' => $userDetails->phone,
            ];
    
            if ($address) {
                $field = [
                    'value' => $address->city->title
                ];
                if ($address->city->type === \App\Address::TYPE_CITY) {
                    $field ['data']['city_fias_id'] = $address->city->id;
                    $field ['data']['city'] = $address->city->title;
                } elseif ($address->city->type === \App\Address::TYPE_SETTLEMENT) {
                    $field ['data']['settlement_fias_id'] = $address->city->id;
                    $field ['data']['settlement'] = $address->city->title;
                }
                $fields ['delivery_city'] = $field;
            }
    
            if ($address->street) {
                $fields ['delivery_street'] = [
                    'value' => $address->street->title,
                    'data' => [
                        'street_fias_id' => $address->street->id,
                    ]
                ];
            }
    
            if ($address->street_number) {
                $fields ['delivery_house_number'] = [
                    'value' => $address->street_number,
                ];
            }
    
            if ($address->flat) {
                $fields ['delivery_flat_number'] = $address->flat;
            }
    
            $fields = (object)$fields;
    
            $actions = [
                'remove' => route('shop.cart.remove'),
                'remove_gift_card' => route('shop.cart.gift-cards.remove'),
                'change' => route('shop.cart.update'),
                'promo' => route('shop.coupon.apply'),
                'checkout' => route('orders.store'),
                'get_pickups' => route('delivery_points.index'),
                'check_email' => route('check_email'),
            ];
    
            return view('shop.cart.index', compact(
                'items',
                'address',
                'couponCode',
                'fields',
                'actions'
            ));
        }

    this is MVC, baby !

    hrustbb2, 31 Августа 2020

    Комментарии (0)
  4. PHP / Говнокод #26886

    −1

    1. 1
    2. 2
    3. 3
    4. 4
    5. 5
    6. 6
    7. 7
    8. 8
    9. 9
    private function changePlans(Coupon $coupon): Coupon
    {
            $coupon->paypal_plan_yearly_rub_id = $this->getPaypalId($coupon->billingPlanYearlyRub, $coupon);
            $coupon->paypal_plan_yearly_usd_id = $this->getPaypalId($coupon->billingPlanYearlyUsd, $coupon);
            $coupon->paypal_plan_monthly_rub_id = $this->getPaypalId($coupon->billingPlanMonthlyRub, $coupon);
            $coupon->paypal_plan_monthly_usd_id = $this->getPaypalId($coupon->billingPlanMonthlyUsd, $coupon);
    
            return $coupon;
    }

    Вот это забавно $this->getPaypalId($coupon->billingPlanMonthlyUsd, $coupon); (getPaypalId приватный)

    hrustbb2, 20 Августа 2020

    Комментарии (13)